Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Test Minimum Version CI Job #109

Merged
merged 5 commits into from
Jun 7, 2022

Conversation

echarles
Copy link
Member

@echarles echarles commented Jun 3, 2022

This PR bumps the minimum required version of jupyter_client to fit the one defined in jupyter_server

@echarles echarles added the bug Something isn't working label Jun 3, 2022
@echarles
Copy link
Member Author

echarles commented Jun 3, 2022

@blink1073 I am running this flow on my MacOs Laptop and it succeeds.

platform darwin -- Python 3.9.12, pytest-7.1.2, pluggy-1.0.0 -- /Users/echarles/opt/miniconda3/envs/tmp/bin/python3.9
cachedir: .pytest_cache
rootdir: /Users/echarles/datalayer/ext/jupyter-notebook-classic, configfile: pyproject.toml, testpaths: tests
plugins: anyio-3.6.1, tornasync-0.6.0.post2, nbval-0.9.6, cov-3.0.0
collected 3 items                                                                                                                                             

tests/test_notebookapp.py::test_tree_handler PASSED                                                                                                     [ 33%]
tests/test_notebookapp.py::test_notebook_handler PASSED                                                                                                 [ 66%]
tests/test_notebookapp.py::test_terminal_handler PASSED      

whereas it fails on the CI.

self = <jupyter_server.serverapp.ServerApp object at 0x7fed8b442e90>
filename = 'jupyter_config'
path = ['/home/runner/work/nbclassic/nbclassic', '/tmp/pytest-of-runner/pytest-1/test_notebook_handler0/config', '/tmp/pytest.../pytest-1/test_notebook_handler0/env/etc/jupyter', '/tmp/pytest-of-runner/pytest-1/test_notebook_handler0/etc/jupyter']
    @catch_config_error
    def load_config_file(self, filename, path=None):
        """Load config files by filename and path."""
        filename, ext = os.path.splitext(filename)
        loaded = []
        for config in self._load_config_files(filename, path=path, log=self.log,
>           raise_config_file_errors=self.raise_config_file_errors,
        ):
E       RuntimeError: generator raised StopIteration

@blink1073
Copy link
Contributor

You tested locally with the minimum version of jupyter_server?

@echarles
Copy link
Member Author

echarles commented Jun 4, 2022

I have pip installed from source, which installs jupyter-server 1.17.0.

@blink1073
Copy link
Contributor

The version used in the min version test is 1.8. It looks like that needs to be bumped to a higher version.

@echarles
Copy link
Member Author

echarles commented Jun 4, 2022

I have bumped jupyter-server>=1.17.0 and get the same exception.

@blink1073
Copy link
Contributor

I'm not sure then, I don't have the bandwidth to dive in on this, I'd say remove the CI job.

@echarles
Copy link
Member Author

echarles commented Jun 6, 2022

I have tried also with different python versions without luck. I will disable the job.

@echarles echarles marked this pull request as ready for review June 7, 2022 06:50
@echarles echarles changed the title Fix Test Minimum Version CI Job Disable Test Minimum Version CI Job Jun 7, 2022
@echarles
Copy link
Member Author

echarles commented Jun 7, 2022

@blink1073 I have disabled the failing test in the job, and now CI is green 👌

Screenshot 2022-06-07 at 08 50 20

I have renamed this PR to Disable... and added a note on #100 (comment)

This is ready to be merged.

@blink1073
Copy link
Contributor

Great, thanks!

@blink1073 blink1073 merged commit d756b4c into jupyter:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants