-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Test Minimum Version
CI Job
#109
Conversation
@blink1073 I am running this flow on my MacOs Laptop and it succeeds.
whereas it fails on the CI.
|
You tested locally with the minimum version of |
I have pip installed from source, which installs |
The version used in the min version test is 1.8. It looks like that needs to be bumped to a higher version. |
I have bumped jupyter-server>=1.17.0 and get the same exception. |
I'm not sure then, I don't have the bandwidth to dive in on this, I'd say remove the CI job. |
I have tried also with different python versions without luck. I will disable the job. |
Test Minimum Version
CI JobTest Minimum Version
CI Job
@blink1073 I have disabled the failing test in the job, and now CI is green 👌 I have renamed this PR to This is ready to be merged. |
Great, thanks! |
This PR bumps the minimum required version of
jupyter_client
to fit the one defined injupyter_server