Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add messaging docs for optional features and kernel subshells #1045

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ianthomas23
Copy link
Contributor

This adds messaging documentation for optional features JEP92 and kernel subshells JEP91.

Summary of changes:

  • Optional features JEP92:

    • Return optional supported_features in kernel_info_reply.
    • Deprecate use of debugger in kernel_info_reply as this is replaced by supported_features=['debugger']. It will have to be a long deprecation period whilst other libraries in the Jupyter ecosystem adopt use of supported_features.
  • Kernel subshells JEP91:

    • Return supported_features=['kernel subshells'] in kernel_info_reply.
    • New control request/reply messages for create, delete and list subshells.
    • Add optional subshell_id to message header.

The version added/changed for all of these is 5.5. I am unsure of the protocol around official releases here.

Copy link
Member

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ianthomas23.
Just one minor comment: should we use capital letters for "ID"? I see we use both "ID" and "id" in the current documentation, but I would prefer "ID".

@ianthomas23
Copy link
Contributor Author

Just one minor comment: should we use capital letters for "ID"? I see we use both "ID" and "id" in the current documentation, but I would prefer "ID".

Good idea. I've switched to using "ID" throughout the messaging page for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants