Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Clarify social media posting guideline" #240

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

Ruv7
Copy link
Contributor

@Ruv7 Ruv7 commented Oct 22, 2024

Reverts #239 - Charter changes need to. be reviewed by the EC.

@jasongrout
Copy link
Member

jasongrout commented Oct 24, 2024

Thanks. It does look like this PR was supposed to go under additional review before merging. We should have a mechanism for noting in PRs when additional approval is desired.

@jasongrout jasongrout merged commit a1118f2 into main Oct 24, 2024
1 check passed
@ivanov
Copy link
Member

ivanov commented Oct 27, 2024

Ana and Jason: when you don't reach out to provide feedback that something has gone against your rules, people will either likely do it again, or lose trust and bounce off when they find out they are being routed around.

I would have appreciated at @ mention here.

@jasongrout
Copy link
Member

@ivanov, first, thanks for cleaning up a bunch of things around here. I noticed you were doing some general housekeeping that was long overdue over the past few days - much appreciated. And noted that mentioning you here would have been good - sorry.

With that particular PR, my understanding from discussion was that it was supposed to have had some more context and a call for review, but that info wasn't yet added to the PR to signal to everyone that it was opening a discussion and was a WIP at this point. We should also have reached out to @andrii-i here as well. @andrii-i, just to be clear, was your intention in #239 to open a discussion about that change?

@ivanov
Copy link
Member

ivanov commented Oct 27, 2024

I assume @andrii-i was made aware since he opened #242

@andrii-i
Copy link
Contributor

@jasongrout @ivanov Thank you both for looking into this, I have opened #242 as a draft with a sufficient description as the intention indeed was to open a discussion on the subject.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants