Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate start-notebook & start-singleuser to python #2006

Merged
merged 18 commits into from
Oct 17, 2023
Merged

Migrate start-notebook & start-singleuser to python #2006

merged 18 commits into from
Oct 17, 2023

Commits on Oct 17, 2023

  1. Migrate start-notebook.sh to bash 

    Based on

> Stop using bash, haha 👍

from jupyter#1532.

If there's more apetite for this, I'll try to migrate
`start.sh` and `start-singleuser.sh` as well - I think they should
all be merged together. We can remove the `.sh` suffixes for
accuracy, and keep symlinks in so old config still works. Since
the shebang is what is used to launch the correct interpreter,
the `.sh` doesn't matter.

Will help fix jupyter#1532,
as I believe all those things are going to be easier to do from
python than bash
    @yuvipanda
    yuvipanda committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    d1ff010 View commit details
    Browse the repository at this point in the history

  2. Rename start-notebook.sh to start-notebook

    @yuvipanda
    yuvipanda committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    ed70463 View commit details
    Browse the repository at this point in the history

  3. Cleanup start-notebook a little

    @yuvipanda
    yuvipanda committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    00e751e View commit details
    Browse the repository at this point in the history

  4. Fix typo

    @yuvipanda
    yuvipanda committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    ea06768 View commit details
    Browse the repository at this point in the history

  5. Migrate start-singleuser as well

    @yuvipanda
    yuvipanda committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    14a1e8c View commit details
    Browse the repository at this point in the history

  6. Remove unused import

    @yuvipanda
    yuvipanda committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    40f37d7 View commit details
    Browse the repository at this point in the history

  7. Run symlink commands as root

    @yuvipanda
    yuvipanda committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    3364294 View commit details
    Browse the repository at this point in the history

  8. Combine repetitive RUN commands

    @yuvipanda
    yuvipanda committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    bb98d5e View commit details
    Browse the repository at this point in the history

  9. Remove multiple args to env 

    -u can not be set by shebang, we must set the env var
instead
    @yuvipanda
    yuvipanda committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    9e71839 View commit details
    Browse the repository at this point in the history

  10. Fix conditional inversion 

    Co-authored-by: Ayaz Salikhov <[email protected]>
    @yuvipanda @mathbunnyru
    yuvipanda and mathbunnyru committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    67302e3 View commit details
    Browse the repository at this point in the history

  11. Fix how start-singleuser is exec'd

    @yuvipanda
    yuvipanda committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    1804a8c View commit details
    Browse the repository at this point in the history

  12. Actually call jupyterhub-singleuser in start-singleuser

    @yuvipanda
    yuvipanda committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    527b756 View commit details
    Browse the repository at this point in the history

  13. Pass through any additional args we get

    @yuvipanda
    yuvipanda committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    9f7bdb3 View commit details
    Browse the repository at this point in the history

  14. Put .py suffix on the start-* scripts

    @yuvipanda
    yuvipanda committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    37d5b15 View commit details
    Browse the repository at this point in the history

  15. Add .sh shims for the start-* scripts

    @yuvipanda
    yuvipanda committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    81c67ef View commit details
    Browse the repository at this point in the history

  16. Document start-notebook.sh and start-singleuser.sh

    @yuvipanda
    yuvipanda committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    219cf36 View commit details
    Browse the repository at this point in the history

  17. Partially test start-notebook.sh

    @yuvipanda
    yuvipanda committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    d6519ac View commit details
    Browse the repository at this point in the history

  18. Reflow warning docs 

    Co-authored-by: Ayaz Salikhov <[email protected]>
    @yuvipanda @mathbunnyru
    yuvipanda and mathbunnyru authored Oct 17, 2023
    Configuration menu
    Copy the full SHA
    99410dc View commit details
    Browse the repository at this point in the history