-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 MVP launch buttons for JupyterHub & MyBinder #503
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Quick thoughts from me:
Overall - the UX you describe above seems like a good first step for an MVP - it roughly mimics the behavior of Jupyter Book and would let users get started if they were already relying on that feature. |
@@ -24,6 +24,7 @@ | |||
"@heroicons/react": "^2.0.18", | |||
"@radix-ui/react-icons": "^1.3.2", | |||
"@radix-ui/react-popover": "^1.1.2", | |||
"@radix-ui/react-tabs": "^1.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
function LaunchButton(props: { github: string; location: string; binder?: string }) { | ||
const binder = props.binder ?? 'https://mybinder.org'; | ||
type CommonLaunchProps = { | ||
github: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we generalize in our naming a bit more? as in:
git: <url>
provider: 'github'
thebe does that, as the intention is to support git interface/protocol.
or are we happy with
github: 'https://gitlab.myinstitution.org/...'
Also I realise that we only have github
in the frontmatter, but I am imagining that this git info will in future come from a more dedicated frontmatter.services
block or the like which may have non github specific fields, like the one I suggest there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, entirely! I'm going to take inspiration from some of the jb1 config here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we do need to change our frontmatter; GitHub should not be the only Git repo that we can define in our frontmatter.
I would probably have frontmatter fields for github
, gitlab
, etc. that are normalised to a git
field i.e. mystmd
should know how to build canonical URLs for those providers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
d35cb27
to
e2f97b8
Compare
I've added support for basic validation using Radix Form: I think this is good to go for a WIP. I'm keen to ship this in time for AGU, so I'm not exporting it intentionally. We can also disable it by default if that provides less concern for @stevejpurves et al. to ship. Any review welcome. |
To close jupyter-book/mystmd#1643 and jupyter-book/mystmd#1644, this PR prototypes a launch UI. We will want to move things around in time, but this PR is designed to start design conversations.
There are some deeper conversations around environment provisioning, and execution strategies. They should be ignored for the purpose of this MVP.
Open questions
Zero-
mystmd
-changes MVPHEAD
Kitchen-sink solution