🪄 Add more class support to directives
#500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 196e7ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Could someone clarify whether we expect AST nodes to always have |
|
If there is an identifier, there should be an html_id always. If there isn't that is a bug. Those in the theme and there for legacy likely., or if we need the node to be identified, prefer the I'd and fall back to the key in the order: html_id, identifier, key. |
fwkoch
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should increase the number of directives that support
classandidentifierin rendering. I doubt I've got them all, but I created a test case from the directives list: https://mystmd.org/guide/directivesDetails
:::{aside} An Optional Title :class: red This is an aside. It is not entirely relevant to the main article. ::: :::{tip} :class: red Try changing `tip` to `warning`! ::: :::{bibliography} :class: red ::: :::{blockquote} :name: quote :class: red Hello -- world ::: :::{code} python :class: red x + y ::: :::{div} :class: red div ::: :::{dropdown} :class: red dropdown ::: :::{embed} #quote :class: red ::: :::{figure} https://picsum.photos/512 :class: red ::: :::{glossary} :class: red Foo : Bar ::: :::{iframe} https://google.com :class: red ::: :::{include} test.md :class: red ::: :::{mermaid} :class: red graph LR; dot --> dash; ::: ```{myst} :class: red Try this! ``` ```{table} :class: red | Month | Savings | | -------- | ------- | | January | $250 | | February | $80 | | March | $420 | ```