Test for equality to None with 'is' instead of '==' (ros#355)

* Test for falsehood instead of '=='
jspricke · Jan 23, 2019 · d714a65 · d714a65
1 parent 6223549
commit d714a65
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/tf2_ros/src/tf2_ros/buffer_client.py b/tf2_ros/src/tf2_ros/buffer_client.py
@@ -177,9 +177,9 @@ def __process_goal(self, goal):
         return self.__process_result(self.client.get_result())
 
     def __process_result(self, result):
-        if result == None:
+        if not result:
             raise tf2.TransformException("The BufferServer returned None for result!  Something is likely wrong with the server.")
-        if result.error == None:
+        if not result.error:
             raise tf2.TransformException("The BufferServer returned None for result.error!  Something is likely wrong with the server.")
         if result.error.error != result.error.NO_ERROR:
             if result.error.error == result.error.LOOKUP_ERROR:

diff --git a/tf2_ros/src/tf2_ros/buffer_interface.py b/tf2_ros/src/tf2_ros/buffer_interface.py
@@ -65,7 +65,7 @@ def transform(self, object_stamped, target_frame, timeout=rospy.Duration(0.0), n
         do_transform = self.registration.get(type(object_stamped))
         res = do_transform(object_stamped, self.lookup_transform(target_frame, object_stamped.header.frame_id,
                                                                  object_stamped.header.stamp, timeout))
-        if new_type == None:
+        if not new_type:
             return res
 
         return convert(res, new_type)
@@ -95,7 +95,7 @@ def transform_full(self, object_stamped, target_frame, target_time, fixed_frame,
         res = do_transform(object_stamped, self.lookup_transform_full(target_frame, target_time,
                                                                      object_stamped.header.frame_id, object_stamped.header.stamp, 
                                                                      fixed_frame, timeout))
-        if new_type == None:
+        if not new_type:
             return res
 
         return convert(res, new_type)