refactor: add declare strict_types to all classes in ./src #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DannyvdSluijs
force-pushed
the
Add-declare-strict_types
branch
from
c74658f
to
61c2dd8
Compare
DannyvdSluijs
force-pushed
the
Add-declare-strict_types
branch
from
b2dd016
to
0f82775
Compare
DannyvdSluijs
force-pushed
the
Add-declare-strict_types
branch
from
0f82775
to
ce0b1d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the project configuration and codebase to improve code quality and enforce strict typing. The main changes involve removing the PHP CS Fixer configuration file and adding strict type declarations to various files.
Configuration changes:
.php-cs-fixer.dist.phpto streamline project setup and maintenance.Code quality improvements:
declare(strict_types=1);to enforce strict typing in multiple files across thesrc/JsonSchema/Constraintsdirectory, includingBaseConstraint.php,CollectionConstraint.php,ConstConstraint.php,Constraint.php,ConstraintInterface.php,EnumConstraint.php,Factory.php,FormatConstraint.php,NumberConstraint.php,ObjectConstraint.php,SchemaConstraint.php,StringConstraint.php,TypeCheck/LooseTypeCheck.php,TypeCheck/StrictTypeCheck.php,TypeCheck/TypeCheckInterface.php,TypeConstraint.php, andUndefinedConstraint.php. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17]declare(strict_types=1);to enforce strict typing insrc/JsonSchema/ConstraintError.phpandsrc/JsonSchema/Entity/JsonPointer.php. [1] [2]