-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add crossplane 1.15 #395
Conversation
gopisaba
commented
Feb 19, 2024
•
edited
Loading
edited
- add crossplane 1.15
- add upbound aws 1.x versions
- add upbound aws 1.x versions
need some help please. The CI is failing on crossplane. |
I think the problem is that https://doc.crds.dev/raw/github.com/upbound/[email protected] returns 502, there are a lot of CRDs for the AWS provider which causes a timeout. |
Thanks @mikael-lindstrom. I have replaced doc.crds.dev with the github urls. It is long list of crds but it works I think. does it makes sense to you? |
Makes sense as a workaround to me, though the CRD list seems pretty hard to maintain. Not sure if there is any other way to solve it without adding new functionality, maybe the maintainers have some ideas? |
raised an issue on their repo 🤞🏽 |
@mikael-lindstrom - Is it okay to release this with this workaround and when we have answers on this issue, we can fix it here as well? |
I cannot make that call since I'm not a maintainer but maybe @Duologic can assist? |
Running CI... I do not see a big problem in this but Crossplane pushes the boundaries quite a bit. We might want to look at different solutions in the mid-term. Maybe a git subtree or something like that. |
@Duologic ping on this one - I don't see a significant blocker on getting this merged. Wdyt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to generate that long array? This seems unmaintainable over a long period.
Looks like this resolved now but broken again after 1.9.0 :( |
I've made a commit that generates that list, isn't flexible enough yet to support multiple versions but it's a start. |