Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add crossplane 1.15 #395

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Conversation

gopisaba
Copy link
Contributor

@gopisaba gopisaba commented Feb 19, 2024

  • add crossplane 1.15
  • add upbound aws 1.x versions

@Duologic Duologic changed the title feat: add crossplane 1.5 feat: add crossplane 1.15 Mar 5, 2024
- add upbound aws 1.x versions
@gopisaba
Copy link
Contributor Author

need some help please. The CI is failing on crossplane.

@mikael-lindstrom
Copy link
Contributor

I think the problem is that https://doc.crds.dev/raw/github.com/upbound/[email protected] returns 502, there are a lot of CRDs for the AWS provider which causes a timeout.

@gopisaba
Copy link
Contributor Author

gopisaba commented Mar 21, 2024

I think the problem is that https://doc.crds.dev/raw/github.com/upbound/[email protected] returns 502, there are a lot of CRDs for the AWS provider which causes a timeout.

Thanks @mikael-lindstrom. I have replaced doc.crds.dev with the github urls. It is long list of crds but it works I think. does it makes sense to you?

@mikael-lindstrom
Copy link
Contributor

Makes sense as a workaround to me, though the CRD list seems pretty hard to maintain. Not sure if there is any other way to solve it without adding new functionality, maybe the maintainers have some ideas?

@gopisaba
Copy link
Contributor Author

Makes sense as a workaround to me, though the CRD list seems pretty hard to maintain. Not sure if there is any other way to solve it without adding new functionality, maybe the maintainers have some ideas?

raised an issue on their repo 🤞🏽

@gopisaba
Copy link
Contributor Author

@mikael-lindstrom - Is it okay to release this with this workaround and when we have answers on this issue, we can fix it here as well?

@mikael-lindstrom
Copy link
Contributor

@mikael-lindstrom - Is it okay to release this with this workaround and when we have answers on this issue, we can fix it here as well?

I cannot make that call since I'm not a maintainer but maybe @Duologic can assist?

@Duologic
Copy link
Member

Running CI...

I do not see a big problem in this but Crossplane pushes the boundaries quite a bit. We might want to look at different solutions in the mid-term. Maybe a git subtree or something like that.

@xvzf
Copy link
Member

xvzf commented Aug 4, 2024

@Duologic ping on this one - I don't see a significant blocker on getting this merged. Wdyt?

Copy link
Member

@Duologic Duologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to generate that long array? This seems unmaintainable over a long period.

@gopisaba
Copy link
Contributor Author

gopisaba commented Oct 3, 2024

I think the problem is that https://doc.crds.dev/raw/github.com/upbound/[email protected] returns 502, there are a lot of CRDs for the AWS provider which causes a timeout.

Looks like this resolved now but broken again after 1.9.0 :(

@Duologic
Copy link
Member

I've made a commit that generates that list, isn't flexible enough yet to support multiple versions but it's a start.

@Duologic Duologic merged commit 7fa879a into jsonnet-libs:master Oct 11, 2024
68 checks passed
@gopisaba gopisaba deleted the crossplane branch October 11, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants