Defines the pattern for taking unique items from collection of JSONArray #957

PavelSakharchuk · 2023-09-22T09:16:39Z

No description provided.

uarlouski · 2023-09-22T10:52:08Z

json-path/src/main/java/com/jayway/jsonpath/internal/function/sequence/Distinct.java

+public class Distinct implements PathFunction {
+
+    @Override
+    public Object invoke(String currentPath, PathRef parent, Object model, EvaluationContext ctx, List<Parameter> parameters) {


please make sure this function works with arrays of objects as well

Thanks. Added tests on the array of objects and empty array.

valfirst · 2023-09-22T11:28:45Z

json-path/src/main/java/com/jayway/jsonpath/internal/function/sequence/Distinct.java

+            Iterable<?> objects = ctx.configuration().jsonProvider().toIterable(model);
+            Set<Object> objectSet = new HashSet<>();
+            objects.forEach(objectSet::add);
+
+            return  new ArrayList<>(objectSet);


I think Java Stream API can be used

Thanks. Updated

valfirst · 2023-09-22T11:28:57Z

json-path/src/main/java/com/jayway/jsonpath/internal/function/sequence/Distinct.java

+
+    @Override
+    public Object invoke(String currentPath, PathRef parent, Object model, EvaluationContext ctx, List<Parameter> parameters) {
+        if(ctx.configuration().jsonProvider().isArray(model)){


Suggested change

if(ctx.configuration().jsonProvider().isArray(model)){

if (ctx.configuration().jsonProvider().isArray(model)) {

Thanks. Updated

valfirst · 2023-09-22T11:30:10Z

json-path/src/main/java/com/jayway/jsonpath/internal/function/sequence/Distinct.java

+    public Object invoke(String currentPath, PathRef parent, Object model, EvaluationContext ctx, List<Parameter> parameters) {
+        if(ctx.configuration().jsonProvider().isArray(model)){
+            Iterable<?> objects = ctx.configuration().jsonProvider().toIterable(model);
+            Set<Object> objectSet = new HashSet<>();


HashSet may change order

Thanks. Updated

valfirst · 2023-09-22T11:37:04Z

...rc/main/java/com/jayway/jsonpath/internal/function/sequence/AbstractSequenceAggregation.java

@@ -37,7 +37,7 @@ public Object invoke(String currentPath, PathRef parent, Object model, Evaluatio
                }
            }
        }
-        throw new JsonPathException("Aggregation function attempted to calculate value using empty array");
+        throw new JsonPathException("Aggregation function attempted to calculate value using non array");


I guess it should go as a separate commit or even PR

Thanks. Reverted

valfirst · 2023-09-22T11:38:13Z

json-path/src/test/java/com/jayway/jsonpath/internal/function/SequentialPathFunctionTest.java

+
+    @Test
+    public void testDistinctOfObjects() throws Exception {
+        final Object EXPECTED_VALUE = new ObjectMapper().readValue("[{\"a\":\"a-val\"}, {\"b\":\"b-val\"}]", Object.class);


Suggested change

final Object EXPECTED_VALUE = new ObjectMapper().readValue("[{\"a\":\"a-val\"}, {\"b\":\"b-val\"}]", Object.class);

final Object expectedArray = new ObjectMapper().readValue("[{\"a\":\"a-val\"}, {\"b\":\"b-val\"}]", Object.class);

Thanks. Updated

valfirst · 2023-09-22T11:38:24Z

json-path/src/test/java/com/jayway/jsonpath/internal/function/SequentialPathFunctionTest.java

+
+    @Test
+    public void testDistinctOfEmptyObjects() throws Exception {
+        final Object EXPECTED_VALUE = new ObjectMapper().readValue("[]", Object.class);


Suggested change

final Object EXPECTED_VALUE = new ObjectMapper().readValue("[]", Object.class);

final Object expectedArray = new ObjectMapper().readValue("[]", Object.class);

Thanks. Updated

valfirst · 2023-09-23T07:08:39Z

README.md

+| first()    | Provides the first item of an array                                                  | Depends on the array |
+| last()     | Provides the last item of an array                                                   | Depends on the array |
+| index(X)   | Provides the item of an array of index: X, if the X is negative, take from backwards | Depends on the array |
+| distinct() | Provides the unique items of an array                                                | Depends on the array |


Thanks. Updated

valfirst · 2023-09-23T07:12:09Z

json-path/src/test/java/com/jayway/jsonpath/internal/function/BaseFunctionTest.java

    protected static final String TEXT_AND_NUMBER_SERIES = "{\"text\" : [ \"a\", \"b\", \"c\", \"d\", \"e\", \"f\" ], \"numbers\" : [ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10]}";
+    protected static final String OBJECT_SERIES = "{\"empty\": [], \"objects\" : [ {\"a\":   \"a-val\"}, {\"b\": \"b-val\"}, {   \"a\": \"a-val\"} ]}";


what about array of arrays? does it work?

Yes.
I added a test for it.

valfirst · 2023-09-23T07:15:54Z

json-path/src/test/java/com/jayway/jsonpath/internal/function/SequentialPathFunctionTest.java

+
+    @Test
+    public void testDistinctOfObjects() throws Exception {
+        final Object expectedValue = new ObjectMapper().readValue("[{\"a\":\"a-val\"}, {\"b\":\"b-val\"}]", Object.class);


shouldn't conf.mappingProvider() be used instead of explicit creation of ObjectMapper?

Thanks. Updated

valfirst · 2023-09-23T07:16:07Z

json-path/src/test/java/com/jayway/jsonpath/internal/function/SequentialPathFunctionTest.java

+
+    @Test
+    public void testDistinctOfEmptyObjects() throws Exception {
+        final Object expectedValue = new ObjectMapper().readValue("[]", Object.class);


shouldn't conf.mappingProvider() be used instead of explicit creation of ObjectMapper?

Thanks. Updated

PavelSakharchuk force-pushed the distinct branch from 512b14a to eadcd79 Compare September 22, 2023 09:17

uarlouski reviewed Sep 22, 2023

View reviewed changes

valfirst suggested changes Sep 22, 2023

View reviewed changes

PavelSakharchuk force-pushed the distinct branch from eadcd79 to c54fba6 Compare September 22, 2023 11:34

valfirst suggested changes Sep 22, 2023

View reviewed changes

PavelSakharchuk force-pushed the distinct branch from c54fba6 to 6f197e0 Compare September 22, 2023 11:47

valfirst suggested changes Sep 23, 2023

View reviewed changes

PavelSakharchuk force-pushed the distinct branch from 6f197e0 to 3017d47 Compare October 2, 2023 19:11

Defines the pattern for taking unique items from collection of JSONArray

e707a46

PavelSakharchuk force-pushed the distinct branch from 3017d47 to e707a46 Compare October 2, 2023 19:17

PavelSakharchuk requested review from uarlouski and valfirst October 8, 2023 20:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Defines the pattern for taking unique items from collection of JSONArray #957

Defines the pattern for taking unique items from collection of JSONArray #957

PavelSakharchuk commented Sep 22, 2023

uarlouski Sep 22, 2023

PavelSakharchuk Sep 22, 2023

valfirst Sep 22, 2023

PavelSakharchuk Sep 22, 2023

valfirst Sep 22, 2023

PavelSakharchuk Sep 22, 2023

valfirst Sep 22, 2023

PavelSakharchuk Sep 22, 2023

valfirst Sep 22, 2023

PavelSakharchuk Sep 22, 2023

valfirst Sep 22, 2023

PavelSakharchuk Sep 22, 2023

valfirst Sep 22, 2023

PavelSakharchuk Sep 22, 2023

valfirst Sep 23, 2023

PavelSakharchuk Oct 2, 2023

valfirst Sep 23, 2023

PavelSakharchuk Oct 2, 2023

valfirst Sep 23, 2023

PavelSakharchuk Oct 2, 2023

valfirst Sep 23, 2023

PavelSakharchuk Oct 2, 2023

	if(ctx.configuration().jsonProvider().isArray(model)){
	if (ctx.configuration().jsonProvider().isArray(model)) {

	final Object EXPECTED_VALUE = new ObjectMapper().readValue("[{\"a\":\"a-val\"}, {\"b\":\"b-val\"}]", Object.class);
	final Object expectedArray = new ObjectMapper().readValue("[{\"a\":\"a-val\"}, {\"b\":\"b-val\"}]", Object.class);

	\| distinct() \| Provides the unique items of an array \| Depends on the array \|
	\| distinct() \| Provides an array containing only unique items from the input array \| List<E> \|

		protected static final String TEXT_AND_NUMBER_SERIES = "{\"text\" : [ \"a\", \"b\", \"c\", \"d\", \"e\", \"f\" ], \"numbers\" : [ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10]}";
		protected static final String OBJECT_SERIES = "{\"empty\": [], \"objects\" : [ {\"a\": \"a-val\"}, {\"b\": \"b-val\"}, { \"a\": \"a-val\"} ]}";

Defines the pattern for taking unique items from collection of JSONArray #957

Are you sure you want to change the base?

Defines the pattern for taking unique items from collection of JSONArray #957

Conversation

PavelSakharchuk commented Sep 22, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment