Add javascript to make work in Electron out of box #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephernest
reviewed
Nov 4, 2017
index.html
Outdated
| @@ -80,6 +80,7 @@ | |||
|
|
|||
| </head> | |||
| <body class="fixedheight"> | |||
| <script>if (typeof module === 'object') { window.module = module; module = undefined; }</script> | |||
There was a problem hiding this comment.
Let's do:
<script>if (typeof module === 'object') { window.module = module; module = undefined; }</script> // to make it work with Electron: https://github.com/electron/electron`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the following lines makes this work in an Electron environment out of the box (without affecting the browser environment).
Changes made per: https://stackoverflow.com/questions/32621988/electron-jquery-is-not-defined