Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Tags: Fix broken aliases in routing #44515

Open
wants to merge 3 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Nov 23, 2024

Pull Request for Issue #42208.

Summary of Changes

The tags router currently does not fix incomplete URL parts like other components. Specifically it does not look up the alias for tags which were only references by an ID and didn't have the slug like expected. The code also unifies the IDs to be arrays as expected.

Testing Instructions

Look up the ID of a tag of your choice which isn't directly linked via a menu item. Go into an article of your choosing and insert the following:

<a href="index.php?option=com_tags&view=tag&id=5">Test</a>

Adapt the &id=5 to the ID of your chosen tag.

Actual result BEFORE applying this Pull Request

The URL will look something like this: `http://domain.tld/tags-component/all-tags/5.html

Expected result AFTER applying this Pull Request

The URL will look something like this: `http://domain.tld/tags-component/all-tags/lime.html

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Nov 26, 2024

I have tested this item ✅ successfully on 6d553a9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44515.

1 similar comment
@fgsw
Copy link

fgsw commented Nov 26, 2024

I have tested this item ✅ successfully on 6d553a9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44515.

@alikon
Copy link
Contributor

alikon commented Nov 26, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44515.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature PR-5.3-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants