-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.3] contact thumbnail image #44502
base: 5.3-dev
Are you sure you want to change the base?
Conversation
Signed-off-by: BrianTeeman <[email protected]>
Signed-off-by: BrianTeeman <[email protected]>
administrator/components/com_admin/sql/updates/postgresql/5.3.0-2024-11-21.sql
Outdated
Show resolved
Hide resolved
Signed-off-by: BrianTeeman <[email protected]>
I have tested this item ✅ successfully on 31c8bfc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44502. |
@ChristineWk thanks for testing but this is still a draft and not ready for testing @chmst The problem here is what do we do with existing contacts? |
Signed-off-by: BrianTeeman <[email protected]>
This reverts commit 2e2534b.
Pull Request for Issue # .
Summary of Changes
When adding a thumbnail image for a contact it was hard coded to use the contact name as the alt text description. This is an invalid use of the alt text description.
This PR adds the ability to create your own valid alt text description or to mark it as a decorative image
Doing this in a way that is backwards compatible is challenging - still testing that
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed