[5.3] Smart Search: Improve Indexer::optimize() #44485
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this PR fix issue #44470 ? |
|
It should greatly improve the situation. I'm not going to guarantee anything, but it is worth a try. |
Quy
reviewed
Nov 19, 2024
Co-authored-by: Quy <[email protected]>
|
I have tested this item ✅ successfully on 253cf3d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44485. |
|
I have tested this item ✅ successfully on 253cf3d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44485. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44485. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR does several optimizations for the optimize step of the indexing in Smart Search. With the current order, the count of links to terms is not updated and terms are deleted before other orphaned data might be removed. At the same time it uses a different method to delete orphaned taxonomies. Running the normal Table::delete() operation on the nested set table class of the taxonomy table is VERY expensive and takes ages. This new code deletes all orphaned leaf nodes in one step, then rebuilds the tree and the path and then tries that again until there are no orphaned leaf nodes anymore. This is by far quicker than the old method.
Testing Instructions
Make sure that you have a sizeable Smart Search index. Go into the #__finder_links table and delete one or several rows. Now in the Index view of Smart Search click on Maintenance => Optimize.
Actual result BEFORE applying this Pull Request
Optimize step takes quite some time and doesn't necessarily delete orphaned terms.
Expected result AFTER applying this Pull Request
Optimize step is far quicker and deletes all orphaned terms.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed