Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debugusergroup for the superuser group #44419

Closed
wants to merge 2 commits into from

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Nov 6, 2024

Pull Request for Issue #44416 .

Summary of Changes

The group of super users has all permissions per default, this is why the check for permission fails.
The PR sets a switch for super user Group.

Remark:
As the super user has all permissions, we as well could remove the "show permissions " link in the Groups list.
Probably this would look like a bug "misssing permission button" for novice users, so I have chosen this solution.

Testing Instructions

See #44416.
Check the group permissions of different groups, not only the super user group, before and after patch.

Actual result BEFORE applying this Pull Request

see #44416.

Expected result AFTER applying this Pull Request

The super user has all permissions
grafik

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Nov 6, 2024

I have tested this item ✅ successfully on bae022a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44419.

1 similar comment
@fgsw
Copy link

fgsw commented Nov 7, 2024

I have tested this item ✅ successfully on bae022a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44419.

@Quy
Copy link
Contributor

Quy commented Nov 7, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44419.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 7, 2024
@HLeithner
Copy link
Member

I would say it's expected behavior to not show all checkboxes green, since super user is a completely different thing it's also marked at the top line correctly. If you would like to see the permissions of a super user you can't see it anymore after this.

This PR is wrong and the bug is not a bug instead it's feature. I would suggest to close this.

@chmst
Copy link
Contributor Author

chmst commented Nov 7, 2024

I don't agree that it is intended behaviour to se that the super user group has no permission for anything. But will happy to test a better solution for this issue.

@chmst chmst closed this Nov 7, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants