Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] ContentHistoryHelper prepared statements #26033

Merged
merged 9 commits into from
Sep 30, 2019
Merged

[4.0] ContentHistoryHelper prepared statements #26033

merged 9 commits into from
Sep 30, 2019

Conversation

SharkyKZ
Copy link
Contributor

Summary of Changes

Adds prepared statements to Joomla\CMS\Helper\ContentHistoryHelper.

Testing Instructions

Simple queries, code review is fine.

Documentation Changes Required

No.

@richard67
Copy link
Member

I have tested this item ✅ successfully on fb74f6a

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26033.

@alikon
Copy link
Contributor

alikon commented Aug 27, 2019

I have tested this item ✅ successfully on f716279


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26033.

@alikon
Copy link
Contributor

alikon commented Aug 27, 2019

i know that this is out of scope from this pr, but just saw this


and for "curly braces for PHP 7.4 compatibility" something like your #25782 ....

p.s.
dont' hate me 😄

@HLeithner
Copy link
Member

i know that this is out of scope from this pr, but just saw this

and for "curly braces for PHP 7.4 compatibility" something like your #25782 ....
p.s.
dont' hate me

That's not wrong thats the correct syntax to access an variable object variable. PHP 7.4 deprecated accessing string indexes with this synatx $string{0} is not allowed anymore it have to be $string[0].

@alikon
Copy link
Contributor

alikon commented Aug 27, 2019

oops 🤒

@Quy
Copy link
Contributor

Quy commented Sep 19, 2019

I have tested this item ✅ successfully on f716279


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26033.

@Quy
Copy link
Contributor

Quy commented Sep 19, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26033.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 19, 2019
@wilsonge wilsonge merged commit 75f1e38 into joomla:4.0-dev Sep 30, 2019
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 30, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Sep 30, 2019
@SharkyKZ SharkyKZ deleted the j4/prepared/ContentHistoryHelper branch September 30, 2019 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants