-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] ContentHistoryHelper prepared statements #26033
[4.0] ContentHistoryHelper prepared statements #26033
Conversation
I have tested this item ✅ successfully on fb74f6a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26033. |
I have tested this item ✅ successfully on f716279 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26033. |
i know that this is out of scope from this pr, but just saw this
and for "curly braces for PHP 7.4 compatibility" something like your #25782 .... p.s. |
That's not wrong thats the correct syntax to access an variable object variable. PHP 7.4 deprecated accessing string indexes with this synatx $string{0} is not allowed anymore it have to be $string[0]. |
oops 🤒 |
I have tested this item ✅ successfully on f716279 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26033. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26033. |
Thanks! |
Summary of Changes
Adds prepared statements to
Joomla\CMS\Helper\ContentHistoryHelper
.Testing Instructions
Simple queries, code review is fine.
Documentation Changes Required
No.