Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: logging to file & additional minor #248

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Feature: logging to file & additional minor #248

wants to merge 1 commit into from

Conversation

zufardhiyaulhaq
Copy link

This PR adding a logging to file feature. another additional minor like:

  • adding Dockerfile.development for development purpose
  • applying logging configuration to HTTP logger

Testing in staging environment with image zufardhiyaulhaq/acme-dns:master.

JSON logs example:
image

Text log example:
image

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 90.898% when pulling 164bef6 on zufardhiyaulhaq:master into 19069f5 on joohoi:master.

@zufardhiyaulhaq
Copy link
Author

@joohoi can you check this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zufardhiyaulhaq @coveralls