Fixes state issue & Uses more accurate events #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1)
I removed all trailing spaces I could find, because it got annoying to work with otherwise
(2)
I looked into the sortable-tree library, because the way you fixed it, one sometimes got the tree twice, which was annoying. One case where that would happen is:
This is a bug in that library I made a PR there fixing it and added the version from my fork to this repository. I also removed the old error recovery mechanism, because it's now obsolete.
(3)
I fixed the registered event handlers to better capture all necessary events. I'm still not quite sure there but I think this now makes the tree feel more responsive.