Match aws secrets manager support #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanogn
pushed a commit
that referenced
this pull request
Dec 19, 2022
…astlane#20726) * Get resolution center threads * Add models for resolution messages and rejections * Add resolution center calls to tunes client * fix rubocop findings * Add ability to get resolution center messages from ReviewSubmission (#1) * Fix list issues * Added comment about only available with Apple ID auth Co-authored-by: Addison Brickey <[email protected]> Co-authored-by: Josh Holtz <[email protected]>
Match import expose api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
It adds support for AWS Secrets manager as a storage backend.
S3 is as secure if configured properly, but it has a bad reputation.
Resolves #999999
Description
Added AWS Secrets manager as a storage backend. It follows the same principles as the S3 backend.
Tested through unit tests and inside a live project.
Testing Steps
Configure secrets manager as the backend in the Matchfile.