chore: Switch default image to Venafi public registry #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Fiddes <[email protected]>
Signed-off-by: Peter Fiddes <[email protected]>
|
@hawksight, I believe it's essential to maintain consistency across the image versions and Helm charts. |
|
Thanks @achuchev for picking up the above. I'm happy to go either way. But keeping them in sync might require some release process setup. I suggest we take that offline to setup. This PR was just example where versions could become skewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Venafi has it's public registry with the
venafi-agentimage published, this naming makes more sense to align with this chart.I'm leaving this in draft because now we have a version disparity between the chart version & the appVersion. I think Venafi product is keen to keep this in line, but this repository has no guidelines or process to ensure that.
Will discuss before making this ready to review.
For now we could bump some deps and release v0.1.44 of the container image and release this chart change in sync.
But I would rather we set a process for this.