Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create strings.xml #151

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Create strings.xml #151

wants to merge 6 commits into from

Conversation

liveasx
Copy link

@liveasx liveasx commented Jan 26, 2017

No description provided.

@jensstein
Copy link
Owner

hi, thanks a lot for your contributions :)
to make the translation work, you need to move strings.xml into values-zh-rCN.
also, could i get you to be a little more descriptive in your commit messages? mentioning that you update strings.xml for chinese would be nice.
and lastly: i really appreciate your work and it will be merged as soon as strings.xml is in the right directory, but translation work is probably best done via transifex.

thanks again :)

@liveasx
Copy link
Author

liveasx commented Feb 18, 2017

You did not give me transifex permission, i can only submit here in Github

@jensstein
Copy link
Owner

i'm so sorry, i don't know how i missed that. you should have permissions now.
but i think it's easier if we do the first import of the translation through git.

the only problem right now is that your changes don't compile. res/values-zh-rCN/strings.xml:L.101 has apostrophes which are not escaped. they need to be written as \' (i would do it myself, but i think it's best that you do it since i can't read the context they are in).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants