Support Docker for Mac #195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use localhost instead of container ip and redirected ports For ActiveMQ
scoheb
reviewed
May 5, 2020
| } else { | ||
| return "tcp://"+ip+":61616"; | ||
| } | ||
| return String.format("tcp://%s:%d", ipBound(61616), port(61616)); |
There was a problem hiding this comment.
I leave have to try this locally...I had issues when I started using podman on Fedora...hence why I had protection if ip was null.
There was a problem hiding this comment.
This will use localhost and port forwarding.
For anybody using mac you can't directly access the container ip, you need to use the forwarded ports
using system property docker.portforward
|
I've changed it so it continues to work as is, but with a system property |
It makes the tests pass but is not the way it should work Use the same port forward before and after restart
This reverts commit cb967fd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use localhost instead of container ip and redirected ports
For ActiveMQ