Prevent deadlock when saving a pipeline job #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So the test failure here: https://ci.jenkins.io/job/Plugins/job/jms-messaging-plugin/job/PR-144/1/testReport/junit/com.redhat.jenkins.plugins.ci.integration/AmqMessagingPluginWithFailoverIntegrationTest/testSimpleCIEventTrigger/ is actually not a failure anymore...but the test should be amended? |
|
the number of threads is 0 when the test fails, so the check for 2 threads different is wrong |
When using the trigger in a pipeline and saving the job configuration the thread stop/start methods are colled twice causing an InterruptedException most times (in a small setup) which leaves the page loading hanging and the thread running in the receive() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the trigger in a pipeline and saving the job configuration
the thread stop/start methods are called twice
causing an InterruptedException most times (in a small setup)
which leaves the page loading hanging and the thread running
in the receive() method