Support UUIDs as tenant ids #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't recommend removing the status log output.. there should be a switch
paramter to reduce it, or else change the LOG state. It really is critical
for debugging devise issues..
…On Tue, Jun 13, 2017 at 8:22 AM Andreas ***@***.***> wrote:
When using UUIDs as your ActiveRecord model ids the current implementation
was not able to handle them. Especially some code required an Integer as
tenant id. These restriction were remove and replaced by the method Milia::Support.
valid_tenant_id?. Also the method where_restrict_tenant was updated to
handle strings within the generated where clause.
------------------------------
You can view, comment on, or merge this pull request online at:
#73
Commit Summary
- Allow strings as tenant_ids to support UUIDs
- Update `where_restrict_tenant` to support string ids
- Remove unnecessary debug output
- Replace Gemfile.lock with origninal content
File Changes
- *M* lib/milia.rb
<https://github.com/jekuno/milia/pull/73/files#diff-0> (1)
- *M* lib/milia/base.rb
<https://github.com/jekuno/milia/pull/73/files#diff-1> (12)
- *A* lib/milia/support.rb
<https://github.com/jekuno/milia/pull/73/files#diff-2> (14)
- *M* test/Gemfile.lock
<https://github.com/jekuno/milia/pull/73/files#diff-3> (4)
- *M* test/test/fixtures/tenants.yml
<https://github.com/jekuno/milia/pull/73/files#diff-4> (4)
- *M* test/test/models/tenant_test.rb
<https://github.com/jekuno/milia/pull/73/files#diff-5> (15)
- *M* test/test/models/user_test.rb
<https://github.com/jekuno/milia/pull/73/files#diff-6> (2)
Patch Links:
- https://github.com/jekuno/milia/pull/73.patch
- https://github.com/jekuno/milia/pull/73.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#73>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAZDDI-M3YG0hfHZMxS_-YIB4O5VCqopks5sDqkegaJpZM4N4p8K>
.
|
|
I think you are referencing my commit message |
|
Anyway I can be of assistance in getting this pull request merged and up and running? |
|
I would appreciate it if @jekuno would merge this pull request too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using UUIDs as your ActiveRecord model ids the current implementation was not able to handle them. Especially some code required an
Integeras tenant id. These restriction were remove and replaced by the methodMilia::Support. valid_tenant_id?. Also the methodwhere_restrict_tenantwas updated to handle strings within the generated where clause.