fix number of rows when using different --size #969

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.43.3
+### Bugfix
+* fix number of rows when using different `--size` [#969](https://github.com/jcubic/jquery.terminal/issues/969)
+
 ## 2.43.2
 ### Bugfix
 * fix scroll to bottom when using `terminal::import_view`

css/jquery.terminal-src.css

@@ -845,6 +845,7 @@ terminal .terminal-output > div {
     }
     .terminal .terminal-output > :not(.raw) > div,
     .cmd div,
+    .terminal,
     .terminal.external div {
         line-height: var(--terminal-line, 1em);
     }

css/jquery.terminal.css

@@ -4,15 +4,15 @@
  *  __ / // // // // // _  // _// // / / // _  // _//     // //  \/ // _ \/ /
  * /  / // // // // // ___// / / // / / // ___// / / / / // // /\  // // / /__
  * \___//____ \\___//____//_/ _\_  / /_//____//_/ /_/ /_//_//_/ /_/ \__\_\___/
- *           \/              /____/                              version 2.43.1
+ *           \/              /____/                              version DEV
  * http://terminal.jcubic.pl
  *
  * This file is part of jQuery Terminal.
  *
  * Copyright (c) 2011-2024 Jakub T. Jankiewicz <https://jcubic.pl/me>
  * Released under the MIT license
  *
- * Date: Sun, 08 Sep 2024 09:58:43 +0000
+ * Date: Sat, 21 Sep 2024 22:04:00 +0000
  */
 .terminal .terminal-output .format, .cmd .format,
 .cmd-prompt, .cmd-prompt div {
@@ -845,6 +845,7 @@ terminal .terminal-output > div {
     }
     .terminal .terminal-output > :not(.raw) > div,
     .cmd div,
+    .terminal,
     .terminal.external div {
         line-height: var(--terminal-line, 1em);
     }

js/jquery.terminal-src.js

@@ -7328,6 +7328,15 @@
         return result;
     }
     // -----------------------------------------------------------------------
+    // :: fix rounding issue #969
+    // -----------------------------------------------------------------------
+    function aproximation(number) {
+        if (number - Math.floor(number) > 0.99) {
+            return Math.ceil(number);
+        }
+        return Math.floor(number);
+    }
+    // -----------------------------------------------------------------------
     // :: calculate numbers of characters
     // -----------------------------------------------------------------------
     function get_num_chars(terminal, char_size) {
@@ -7343,7 +7352,7 @@
     function get_num_rows(terminal, char_size) {
         var filler = terminal.find('.terminal-fill');
         var height = filler.height();
-        return Math.floor(height / char_size.height);
+        return aproximation(height / char_size.height);
     }
     // -----------------------------------------------------------------------
     function all(array, fn) {

js/jquery.terminal.js

@@ -41,7 +41,7 @@
  *
  * broken image by Sophia Bai from the Noun Project (CC-BY)
  *
- * Date: Sun, 15 Sep 2024 23:29:58 +0000
+ * Date: Sat, 21 Sep 2024 22:03:59 +0000
  */
 /* global define, Map, BigInt */
 /* eslint-disable */
@@ -5323,7 +5323,7 @@
     // -------------------------------------------------------------------------
     $.terminal = {
         version: 'DEV',
-        date: 'Sun, 15 Sep 2024 23:29:58 +0000',
+        date: 'Sat, 21 Sep 2024 22:03:59 +0000',
         // colors from https://www.w3.org/wiki/CSS/Properties/color/keywords
         color_names: [
             'transparent', 'currentcolor', 'black', 'silver', 'gray', 'white',
@@ -7328,6 +7328,15 @@
         return result;
     }
     // -----------------------------------------------------------------------
+    // :: fix rounding issue #969
+    // -----------------------------------------------------------------------
+    function aproximation(number) {
+        if (number - Math.floor(number) > 0.99) {
+            return Math.ceil(number);
+        }
+        return Math.floor(number);
+    }
+    // -----------------------------------------------------------------------
     // :: calculate numbers of characters
     // -----------------------------------------------------------------------
     function get_num_chars(terminal, char_size) {
@@ -7343,7 +7352,7 @@
     function get_num_rows(terminal, char_size) {
         var filler = terminal.find('.terminal-fill');
         var height = filler.height();
-        return Math.floor(height / char_size.height);
+        return aproximation(height / char_size.height);
     }
     // -----------------------------------------------------------------------
     function all(array, fn) {