Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude the overview.html javadoc file from source #735

Closed
wants to merge 1 commit into from

Conversation

starksm64
Copy link
Contributor

Fixes #734

Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the issue, this seems rather as a problem with the Jenkins setup then the repo itself? IIUIC, what you're adding would just exclude our own file.
It's also curious that this only happens for the API artifact and not for lang model or EL API 🤔

@Azquelt
Copy link
Contributor

Azquelt commented Jan 16, 2024

I had a look into why this happens. I think it's because we're listing the overview.html as a resource, which is really declaring that it should be included in the output jar. However, for some reason, when targetPath is an absolute path, it doesn't get included in the main jar with that path but does get included in the sources jar. 😕

It looks like it's only been included as a resource in order to enable filtering to replace placeholders in the file? I've made a PR to do this with a separate goal rather than including it as a resource: #745

@Azquelt
Copy link
Contributor

Azquelt commented Jan 16, 2024

This also explains why it doesn't appear in the EL API, that overview file hasn't had placeholders added and isn't configured as a resource.

@starksm64 starksm64 closed this Jan 30, 2024
@Ladicek Ladicek modified the milestone: CDI 4.1 Feb 16, 2024
@starksm64 starksm64 deleted the starksm64-patch-1 branch March 1, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDI-API 4.1 M1 jar contains Jenkins home target folder
4 participants