No throwing #3
Merged
No throwing #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype guards with optional 'errors' arrays
… use ajv as a dependency rather than an externally-provided validator instance
…fe implementation of assign
…sult message types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the project to return validation results and handle validation errors in the same way that
ajvdoes, meaning that validating functions are now implemented as user-defined type guards persisting errors in their respective.errorsproperties.All this is done in support of handling validation errors without
try/catchblocks, which we've seen make a very significant difference in terms of performance.This PR also changes the relationship with
ajv, flagging it as an actual dependency inpackage.jsonto fully control which version ofajvends up being used and the options with which it is instantiated.