-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added separate linking from primary image panel #26
base: master
Are you sure you want to change the base?
Conversation
…ons, updateClickable binding, and this.href setting.
…lick events to fire simultaneously resulting in a lot of open windows.
Is it possible that the mouse pointer over the driving of the picture changes to a finger. Otherwise, the user has no idea that this is a picture link. But one can also think about css: |
…dentify which item to link. Used "all" as an option to enable expansion of this linking property in the future.
Thanks for great addition to primary panel images, but is it possible to make separate links from filmstrip? Maybe add filmstrip to "clickable" string? |
@Didi23: I'm not sure what you mean. Are you referring to making the filmstrip images clickable to the alternate link? |
@joeletherton Yes. I have 2 different images, in primary panel I have advert and in filmstrip I have a brand name thumbnail image so people tend to click on filmstrip instead of primary panel to get to the page with that brand. So I need filmstrip images to be clickable to the alternate link. Can you please help me do it? |
Added an option "filmstrip_use_alt_click" to enable the film strip to be clickable in the same fashion as other images.
@Didi23: I added a new option to the code and some logic to operate it. If you set the boolean "filmstrip_use_alt_click" to true and the image clicked has a non-empty string in the data-href attribute, then it'll behave as if the primary image was clicked. Otherwise it will use default behavior. |
@joeletherton Thank you so much!!! It is exactly what I needed. You made my day. Again, thanks a lot :) |
Added image linking directly for the panel. Added 2 options to support this linking (described below).
The panel itself becomes a clickable link which can redirect to any url specified in the data-href attribute
of the original image html.
New options:
- panel_clickable
- BOOLEAN: flag to indicate that the panel should have a clickable link
- link_newwindow
- BOOLEAN: flag to indicate that panel links should/should not open in a new window
Usage-script:
Usage-html: