add version restore functionality to transport layer #283
Conversation
| @@ -20,14 +20,14 @@ | |||
| "doctrine/dbal": ">=2.4.5,<3.0.x-dev", | |||
| "phpcr/phpcr": "~2.1.2", | |||
| "phpcr/phpcr-utils": "~1.2,>=1.2.6", | |||
| "jackalope/jackalope": "dev-versioning as 1.3.0" | |||
| "jackalope/jackalope": "dev-version-restore as 1.3.0" | |||
|
code looks good, lets see with the jackalpe change and the new tests |
|
@dbu Same here, I rebased, but was the versioning branch already up to date? |
dbu
changed the title
|
i rebased the versioning branch on master, to get the latest fixes. i created a WIP PR for that in #316. can you try to reset this commit onto the other branch? |
|
@dbu Updated, hope I can make some real progress the next weeks... |
|
great! |
|
In order to initialize some nodes with a node type of the |
| @@ -148,6 +150,7 @@ class Client extends BaseTransport implements QueryTransport, WritingInterface, | |||
| */ | |||
| private $coreNamespaces = array( | |||
| NamespaceRegistryInterface::PREFIX_EMPTY => NamespaceRegistryInterface::NAMESPACE_EMPTY, | |||
| NamespaceRegistry::PREFIX_REP => NamespaceRegistry::NAMESPACE_REP, | |||
There was a problem hiding this comment.
@dbu Is this solution ok? Have now moved the constant to jackalope/jackalope instead of phpcr/phpcr.
There was a problem hiding this comment.
yep, i think that is the correct thing to do
This PR adds a call to the restore method of the
VersionHandlerin jackalope/jackalopeNeeds jackalope/jackalope#289 and phpcr/phpcr#93
It also uses the tests added at phpcr/phpcr-api-tests#160