formatting(docstrings): fix common errors #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit be7fc1a.
|
Hey @he11owthere, I know it's a bit late 😅. But is this PR still active? Should I review it or archive it? |
Hey it's still active. Please review it in your free time. Thanks! 😄 |
KareemMAX
suggested changes
Jan 2, 2024
There was a problem hiding this comment.
I'm still not convinced why didn't we use the base class instead and extended it?
|
If you want additional context, we can have a quick call regarding that if you would like @he11owthere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.