Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Extend ivy lint to everything #28649

Closed
wants to merge 9 commits into from
Closed

feat: Extend ivy lint to everything #28649

wants to merge 9 commits into from

Conversation

ogbanugot
Copy link
Contributor

@ogbanugot ogbanugot commented Mar 19, 2024 •
edited
Loading

PR Description

This applies changes from ivy-llc/lint-hook#8

Related Issue

Closes #28448

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

@ivy-leaves ivy-leaves added Paddle Paddle Backend NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist Ivy Functional API Ivy API Experimental Run CI for testing API experimental/New feature or request JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist labels Mar 19, 2024
@vedpatwardhan
Copy link
Contributor

@NripeshN could you please take a look? Thanks @ogbanugot 😄

@vedpatwardhan vedpatwardhan requested review from NripeshN and removed request for vedpatwardhan March 20, 2024 03:57
@NripeshN
Copy link
Contributor

Hey @ogbanugot
Could you create a PR with the changes you made on the lint-hook repo and ask for my review? Once that is merged to main we can use main as the new rev.

@ogbanugot
Copy link
Contributor Author

Hi @NripeshN I have a PR opened here ivy-llc/lint-hook#8, I am unable to request a review but perhaps you can assign it to yourself? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NripeshN NripeshN Awaiting requested review from NripeshN

Assignees

@Ishticode Ishticode

Labels
Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist Paddle Paddle Backend PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend ivy-lint to everything instead of just the frontends
7 participants
@ogbanugot @vedpatwardhan @NripeshN @Ishticode @Sam-Armstrong @ivy-leaves @ivy-branch