-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added the numpy trace function frontend #18016
Conversation
Hi @Maxzeno, Thank you so much for contributing to Ivy. To make sure Ivy is accurate and works the way it is meant to, we implement test functions for every frontend function we implement. Could you please add the corresponding test function for |
@theRealBird Okay |
@theRealBird please review the changes I added a test function for trace as requested by you Thanks |
@theRealBird @ivy-leaves @thecoder12 @edaehn @ Please review and merge my pull request |
Hi @Maxzeno, |
@theRealBird correct me if am wrong but the run_test 1, 14 and some other run test don't pass (I checked a lot of pull requests and noticed the same thing) But I ran my own tests and they passed |
This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days. |
@theRealBird please review again |
Hey! Many apologies for the delayed review of the previous assignee, I've just very recently been assigned to the pr and was about to check the test, but could you please update your branch to the latest master commit so that everything is up to date? I'll try to check back soonest possible on a working day, thanks! |
This PR has been closed because it has been marked as stale for more than 7 days with no activity. |
Close #18013