Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the numpy trace function frontend #18016

Closed
wants to merge 11 commits into from
Closed

Conversation

Maxzeno
Copy link
Contributor

@Maxzeno Maxzeno commented Jun 28, 2023

Close #18013

@ivy-leaves ivy-leaves added the NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist label Jun 28, 2023
@Maxzeno
Copy link
Contributor Author

Maxzeno commented Jun 29, 2023

#18013

@theRealBird
Copy link
Contributor

Hi @Maxzeno,

Thank you so much for contributing to Ivy. To make sure Ivy is accurate and works the way it is meant to, we implement test functions for every frontend function we implement.

Could you please add the corresponding test function for trace? Thanks!

@Maxzeno
Copy link
Contributor Author

Maxzeno commented Jul 9, 2023

@theRealBird Okay

@Maxzeno
Copy link
Contributor Author

Maxzeno commented Jul 25, 2023

@theRealBird please review the changes I added a test function for trace as requested by you

Thanks

@Maxzeno
Copy link
Contributor Author

Maxzeno commented Jul 30, 2023

@theRealBird @ivy-leaves @thecoder12 @edaehn @

Please review and merge my pull request

@theRealBird
Copy link
Contributor

Hi @Maxzeno,
Thank you for your patience and adding the test function. However, it seems that the function is failing the tests. Could you please confirm and fix the errors?

@Maxzeno
Copy link
Contributor Author

Maxzeno commented Jul 31, 2023

@theRealBird correct me if am wrong but the run_test 1, 14 and some other run test don't pass (I checked a lot of pull requests and noticed the same thing)

But I ran my own tests and they passed
if you have the time check my latest commit to this pull request
thank you for your time

@ivy-seed ivy-seed added the Stale label Aug 16, 2023
@ivy-seed
Copy link

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

@Maxzeno
Copy link
Contributor Author

Maxzeno commented Aug 18, 2023

@theRealBird please review again

@ivy-seed ivy-seed assigned juliagsy and unassigned theRealBird Sep 28, 2023
@juliagsy
Copy link
Contributor

Hey! Many apologies for the delayed review of the previous assignee, I've just very recently been assigned to the pr and was about to check the test, but could you please update your branch to the latest master commit so that everything is up to date? I'll try to check back soonest possible on a working day, thanks!

@juliagsy
Copy link
Contributor

juliagsy commented Oct 9, 2023

This PR has been closed because it has been marked as stale for more than 7 days with no activity.

@juliagsy juliagsy closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trace
5 participants