Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling demos tests with nightly binaries #68

Merged
merged 23 commits into from
Nov 14, 2023
Merged

Conversation

vedpatwardhan
Copy link
Contributor

@vedpatwardhan vedpatwardhan commented Nov 9, 2023

  1. Added a way to dispatch the .github/workflows/run-test-suite.yml workflow with an input about whether binaries should be pulled from the nightly branch.
  2. Mounting the volume of the latest clone of ivy everytime rather than the one present inside the docker image that gets updated once a day

@vedpatwardhan
Copy link
Contributor Author

Hey @Dsantra92, here's an example workflow with the nightly binaries, you'd need to go to the workflow page, select the branch as demos_tests_nightly (as we're yet to merge the PR) and pass "true" for the "Testing with nightly binaries : " field as shown in the image to trigger the workflow with the nightly binaries. Let me know if there's any changes to be made, thanks 😄
Screenshot 2023-11-09 at 2 12 53 PM

Copy link
Contributor

@Dsantra92 Dsantra92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some basic formatting changes. Otherwise LGTM.

.github/workflows/_basic-test.yml Show resolved Hide resolved
.github/workflows/_demo-test.yml Outdated Show resolved Hide resolved
.github/workflows/run-test-suite.yml Show resolved Hide resolved
tests/test_demos.sh Outdated Show resolved Hide resolved
tests/test_demos.sh Outdated Show resolved Hide resolved
@Dsantra92
Copy link
Contributor

LGTM. Feel free to merge when it's ready @vedpatwardhan.

@vedpatwardhan
Copy link
Contributor Author

Awesome, thanks @Dsantra92 😄
Also, I saw a nightly branch on the ivy repo as well just like the binaries repo, do you want the demos tests running using the nightly branch binaries to also use the ivy repo's nightly branch?

@Dsantra92
Copy link
Contributor

Yep, we would need the ivy nightly branch. Otherwise new binaries and function definitions wouldn't work.

@vedpatwardhan
Copy link
Contributor Author

Yep, we would need the ivy nightly branch. Otherwise new binaries and function definitions wouldn't work.

done, I'll merge the PR now, but there seems to be an additional test failure in the nightly branch with the torch_to_jax demo as compared to the current code and binaries. I'd suggest looking into that issue before merging the nightly binaries into main. Thanks @Dsantra92 😄

@vedpatwardhan vedpatwardhan merged commit 78234f4 into main Nov 14, 2023
13 of 17 checks passed
@vedpatwardhan vedpatwardhan deleted the demos_tests_nightly branch January 19, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants