-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling demos tests with nightly binaries #68
Conversation
Hey @Dsantra92, here's an example workflow with the nightly binaries, you'd need to go to the workflow page, select the branch as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some basic formatting changes. Otherwise LGTM.
LGTM. Feel free to merge when it's ready @vedpatwardhan. |
Awesome, thanks @Dsantra92 😄 |
Yep, we would need the ivy nightly branch. Otherwise new binaries and function definitions wouldn't work. |
…y tests and the nightly ones otherwise
done, I'll merge the PR now, but there seems to be an additional test failure in the nightly branch with the torch_to_jax demo as compared to the current code and binaries. I'd suggest looking into that issue before merging the nightly binaries into main. Thanks @Dsantra92 😄 |
.github/workflows/run-test-suite.yml
workflow with an input about whether binaries should be pulled from thenightly
branch.ivy
everytime rather than the one present inside the docker image that gets updated once a day