Improve robustness of subshell concurrency tests #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
approved these changes
Oct 25, 2024
|
Merging as it should make things better and I can revisit later to improve further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve robustness of subshell concurrency tests. This is difficult to do as the tests run reliably fine on my dev machine so I am looking at what could theoretically improve the situation and trying it out in CI.
I have moved the
import timeto before starting the time-sensitive subshell code as this should be better than importing it in one subshell (taking an unknown amount of time) or importing it in both subshells at the same time (GIL contention?). If this is not sufficient I could add some threaded synchronisation to the start of the subshell test code to remove any timing variability in sending/receiving zmq messages.