Remove bad pipe message log #1246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
reviewed
Oct 25, 2024
| @@ -215,7 +215,7 @@ async def _handle_pipe_msg(self, msg=None): | |||
| if not self._pipe_flag or not self._is_master_process(): | |||
| return | |||
| if msg[0] != self._pipe_uuid: | |||
| print("Bad pipe message: %s", msg, file=sys.__stderr__) | |||
| # print("Bad pipe message: %s", msg, file=sys.__stderr__) | |||
There was a problem hiding this comment.
These messages do indicate a problem, and should still be logged, not entirely suppressed. The problem comes from the change that sys.__stderr__ is now duplicated and forwarded to users, when this message is meant to only. What we really want to write to is sys.stderr._original_stdstream_copy.
I see two options:
- when we capture the low-level
__stderr__, we could replacesys.__stderr__with the new captured fd, so statements like this do what we originally meant them to (only write to stderr, not captured and forwarded), or - keep capturing
__stderr__and explicitly write to the "truly really actually only original stderr" FD for messages like these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is aimed to remove a log when IOPubThread received a mismatch uuid message.
These mismatch messages appear to originate from some firewall and network related components. Jupyter users don't seem to need this information, however it is displayed on the UX.
I search "Bad pipe message" in whole github repos and there are many ipynb files contains this error.
Some similar issue:
spyder-ide/spyder#20591
#1107