fix(unplugin-vue-i18n): check for vue compiler in directive transform hook #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
userquin
changed the title
userquin
commented
Nov 16, 2024
| vuePluginOptions, | ||
| translationIdentifiers | ||
| ) | ||
| } |
There was a problem hiding this comment.
should we set vuePluginOptions to null if missing compiler?
There was a problem hiding this comment.
Ah, yeah!
vue-i18n directive does not work without Vue compiler for SSR.
if Vue compiler is not specify on vitejs/plugin-vue, unplugin-vue-i18n should output warning.
(I recognize vitejs/plugin-vue has Vue compiler as default)
There was a problem hiding this comment.
Oh that's true, it is about the v-t directive, I'm going to check if ssr is exposed.
If this is only a vite plugin why not just expose the transform hook inside vite?
|
closing this, it is a bug in @vitejs/plugin-vue, compiler not being initialized correctly: vitejs/vite-plugin-vue#475 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #420