Updated README for libxdp #84
Conversation
phansGithub
force-pushed
the
xdp-update
branch
from
69159cc
to
3872797
Compare
Makefile
Outdated
| @echo | ||
| sudo apt update && \ | ||
| sudo apt install -y wget build-essential golang && \ | ||
| sudo wget http://security.ubuntu.com/ubuntu/pool/main/libb/libbpf/libbpf1_1.1.0-1_amd64.deb && \ |
There was a problem hiding this comment.
Indentation here needs fixing
README.md
Outdated
| @@ -97,6 +97,9 @@ The following prerequisites are required to build and deploy the plugins from so | |||
| - **llvm** | |||
| - Compiling the bpf progs for Kind. | |||
| - Install on Ubuntu: `apt install llvm` | |||
| - **libxdp** | |||
| - Same as Libbpf, to load and uload the XDP program onto the network device. | |||
There was a problem hiding this comment.
*unload (spellcheck)
Might be worth adding just a brief about what we're doing - installing libbpf, the wget packages and libxdp.
Also, I think we should be doing a libbpf check on the host first as we're including it as the first step of the libxdp installation:
If not present = first install libbpf
else = install libxdp
If we're to break the installation process to 2 sections (libbpf and libxdp) both steps will be required for the ci-public.yml.
@garyloug, we might discuss this further.
phansGithub
force-pushed
the
xdp-update
branch
7 times, most recently
from
d2cb853
to
d851338
Compare
Makefile
Outdated
| install-xdp: | ||
| @echo "****** Install libxdp ******" | ||
| @echo | ||
| sudo apt update && \ |
There was a problem hiding this comment.
What if someone is running on Fedora, apt instructions won't work.
I don't know about adding this to the Makefile, we don't typically install any other dependencies for the project, we list them in the readme and the expectation is that the user ensures the dependencies are installed.
README.md
Outdated
| @@ -97,6 +97,10 @@ The following prerequisites are required to build and deploy the plugins from so | |||
| - **llvm** | |||
| - Compiling the bpf progs for Kind. | |||
| - Install on Ubuntu: `apt install llvm` | |||
| - **libxdp** | |||
| - Same as Libbpf, to load and unload the XDP program onto the network device. | |||
| - Installation: `make install-xdp` | |||
There was a problem hiding this comment.
| - Installation: `make install-xdp` | |
| - Install on Ubuntu: `make install-xdp` |
Makefile
Outdated
| install-xdp: | ||
| @echo "****** Install libxdp ******" | ||
| @echo | ||
| sudo apt update && \ |
There was a problem hiding this comment.
Alternatively add a check to verify one is running on ubuntu before proceeding.
Signed-off-by: phansGithub <[email protected]>
phansGithub
force-pushed
the
xdp-update
branch
from
d851338
to
6241e24
Compare
phansGithub
changed the title
Note: New libxdp installation commands are unaligned, will fix.