feat(elements): new component 'ino-nav-menu' #1148
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iandi09
changed the title
MariaLStefan
requested changes
Jan 9, 2024
packages/elements/src/components/ino-nav-menu-section/ino-nav-menu-section.tsx
Outdated
Show resolved
Hide resolved
packages/elements/src/components/ino-nav-menu/ino-nav-menu.scss
Outdated
Show resolved
Hide resolved
Comment on lines
226
to
227
| href={`#${id}`} | ||
| onClick={(e) => this.handleAnchorClick(e, id)} |
There was a problem hiding this comment.
Do we even need a href if we prevent the default action through handleAnchorClick? Or is it needed for accessibility reasons?
packages/storybook/src/stories/ino-nav-menu/ino-nav-menu.stories.ts
Outdated
Show resolved
Hide resolved
packages/storybook/src/stories/ino-nav-menu/ino-nav-menu.stories.ts
Outdated
Show resolved
Hide resolved
MariaLStefan
temporarily deployed
to
github-pages
GitHub Actions
Inactive
MariaLStefan
temporarily deployed
to
github-pages
GitHub Actions
Inactive
- add stories for props `sectionName`, `sectionId` & `showTitle`
- use theme - add word-break for sections - remove nesting - tweak paddings
- add max-height to every story to see stickyness of nav
- intersectionObserverConfig - scrollOffset
…tion - allows multiple instances of ino-nav-menu on one page - add possible loading skeleton div (needs to be visually implemented) - add possibility to use own section IDs
…further up in DOM & show functionality better - add `sectionsRenderObserver` before initiating of `ino-nav-menu` section points - add switch to shrink playground and show stickiness of `ino-nav-menu` - add active-section change
- move skeleton-loading to animation - ino-avatar: use new skeleton-loading mixin
…er to init Sections - add Event Emitter for sectionReady in ino-nav-section - needs fix: activeSection cannot be emitted in autodetect right now - needs fix: story for sections does not work, check setSectionsFromProps
# Conflicts: # packages/elements/src/components.d.ts # packages/landingpage/app/[lang]/getting-started/_components/layout.tsx # packages/landingpage/app/[lang]/getting-started/_components/menuSection.tsx # packages/landingpage/app/[lang]/getting-started/_components/navigationMenu.module.scss # packages/landingpage/app/[lang]/getting-started/_components/navigationMenu.tsx # packages/landingpage/app/[lang]/getting-started/angular/angular-guide.mdx # packages/landingpage/app/[lang]/getting-started/javascript/javascript-guide.mdx # packages/landingpage/app/[lang]/getting-started/react/react-guide.mdx # packages/landingpage/app/[lang]/getting-started/vue/vue-guide.mdx # packages/landingpage/utils/elementsWrapper.ts
janivo
force-pushed
the
elements-#1075-ino-nav-menu
branch
from
23ce579
to
bb90469
Compare
# Conflicts: # packages/elements/src/components/ino-snackbar/readme.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1075
Additions
reInitSections()for manual re-initiation of sectionsino-nav-menulies further up in DOM then their corresponding sectionssectionContainerIDfor better autodetection (makes it possible to have multipleino-nav-menuon one page)sectionIDtoino-nav-menu-sectionso that consumers can set their own ids. If not set default to build ID From section nameino-nav-menu-sectionino-nav-menuino-nav-menucan be seenintersectionObserverConfigandscrollOffsetloadingand a skeleton loaderskeleton-loadinganimation from ino-avatar to_animation.scss