This repository has been archived by the owner on Apr 24, 2022. It is now read-only.
Fix crash when switch the data source #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crash steps: 1. set the ViewPagerController’s data source, total count is 10; 2. select the active page as 9; 3, i want to change the data source to another pages, total count maybe is 5. So i call ViewPagerController reloadData. 4. ViewPagerController crash Root Cause is self.activeContentIndex is still 9, NSArray cash when call [self.contents replaceObjectAtIndex:index withObject:[NSNull null]]
|
Tried it on my fork and works like a charm! should be merged as soon as possible |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crash (100%) steps:
is 5. So i call ViewPagerController reloadData.
Root Cause is self.activeContentIndex is still 9, NSArray cash when
call [self.contents replaceObjectAtIndex:index withObject:[NSNull null]]