Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7 added more special cases #21

Closed
wants to merge 2 commits into from

Conversation

Sidharth-Singh10
Copy link

This pull request updates the script by adding more special cases of file types to group them into custom folders.
Changes:

  1. Added support for special cases to group specific file types into custom folders.
  2. Updated the special_cases array with additional patterns and folder names.

@rootCircle
Copy link
Member

Hi @Sidharth-Singh10, congo on the second one! Can you check and fix these warnings? Confirm if you're not getting these warnings?

image

@rootCircle
Copy link
Member

Few points

  • Please add fixes #n in the PR description not in title
  • Add screenshot/video(if required) in PR description as well
  • Write proper commit message, even if they seem relevant to you, it might look odd in commit history if merged!

@rootCircle
Copy link
Member

ping me here when you're done with those, so we can move forward with your PR!

@Sidharth-Singh10
Copy link
Author

@rootCircle
The warning occurs due to the use of "egrep" which is now considered outdated, "grep -E" is now the better alternative to it. Since "egrep" is used in the source code, I did not update the "egrep" to "grep -E" as the issue was to add more special cases.
I can create a new PR to update the same.

@rootCircle
Copy link
Member

The warning occurs due to the use of "egrep" which is now considered outdated, "grep -E" is now the better alternative to it. Since "egrep" is used in the source code, I did not update the "egrep" to "grep -E" as the issue was to add more special cases.

You can update usage of egrep to grep -E in this script only! Use the same PR, need not to create a new PR for it!

Ping me when that's done!

@Sidharth-Singh10
Copy link
Author

@rootCircle
1.Fixed the warning occuring due the use of egrep
2. Fixed the warning occuring due use of ^* in regex

@rootCircle
Copy link
Member

1.Fixed the warning occuring due the use of egrep

  1. Fixed the warning occuring due use of ^* in regex

Looks really great now! Good job @Sidharth-Singh10, accepted!

@rootCircle
Copy link
Member

fixes #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants