OF-2889: i18n properties: don't convert from UTF-8 to Latin1 #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishbowler
force-pushed
the
OF-2889_i18n_utf8
branch
from
ec21f82
to
c459c91
Compare
|
Rebased. |
stokito
commented
Oct 23, 2024
| Java has trouble reading translations from UTF-8 files. To work around that, | ||
| this plugin copies the i18n files from source to the build directory, to be | ||
| modified later by the native2ascii-maven-plugin. | ||
| This plugin copies the i18n files from source to the build directory. | ||
| --> | ||
| <artifactId>maven-resources-plugin</artifactId> | ||
| <version>3.1.0</version> |
There was a problem hiding this comment.
maybe we can eliminate the step to copy resources but not sure if this doesn't broke anything
Fishbowler
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Read but not tested. LGTM. Have checked out https://stackoverflow.com/questions/4659929/how-to-use-utf-8-in-resource-properties-with-resourcebundle and the reasoning stacks up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://igniterealtime.atlassian.net/jira/software/c/projects/OF/issues/OF-2889
Currently the properties files are stored in the UTF-8 and then converted to escaped ISO 8859-1 encoding because use the UTF8 wasn’t properly supported prior Java 9.
Now this is not needed and we can simplify the build.