refactor: replace github.com/ghodss/yaml with sigs.k8s.io/yaml
#3445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juneezee
requested review from
jeronimoalbi,
tbruyelle and
Pantani
as code owners
Pantani
previously approved these changes
Mar 2, 2023
|
@Juneezee can you please add a changelog? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3445 +/- ##
==========================================
+ Coverage 23.45% 23.46% +0.01%
==========================================
Files 298 298
Lines 23510 23525 +15
==========================================
+ Hits 5514 5521 +7
- Misses 17499 17507 +8
Partials 497 497
|
At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <[email protected]>
Signed-off-by: Eng Zer Jun <[email protected]>
ilgooz
approved these changes
Mar 17, 2023
|
Thank you for the contribution! |
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
…gnite#3445) * refactor: replace `github.com/ghodss/yaml` with `sigs.k8s.io/yaml` At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <[email protected]> * Update changelog.md Signed-off-by: Eng Zer Jun <[email protected]> --------- Signed-off-by: Eng Zer Jun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package
github.com/ghodss/yamlis no longer actively maintained. See discussion in ghodss/yaml#75 and ghodss/yaml#80.sigs.k8s.io/yamlis a permanent fork ofgithub.com/ghodss/yaml.The notable change is that
github.com/ghodss/yamlusesgopkg.in/yaml.v2 v2.2.2, butsigs.k8s.io/yamlusesgopkg.in/yaml.v2 v2.4.0. Changes can be seen here v2.2.2...v2.4.0, mostly bug fixes.