-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(steps): add unit test and fix null cols for impute #157
fix(steps): add unit test and fix null cols for impute #157
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
+ Coverage 85.39% 89.35% +3.95%
==========================================
Files 26 28 +2
Lines 1924 2047 +123
==========================================
+ Hits 1643 1829 +186
+ Misses 281 218 -63 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, but maybe more fundamentally—why is this necessary/what motivated it? If somebody wants to fill their missing values with None
, should I care? E.g. maybe they want to represent all the missing value as NULL (and not NaN), so they do this. Alternatively if you see scikit-learn SimpleImputer
, they later let the user customize what is considered "missing".
I'm pushing to deprioritize this beyond today, unless you feel it's particularly pressing. Let's focus on getting the other PRs in for release. |
Instead of raise an error, I change it to throw a warning to the user. User should know the imputing does not work as expected, since there are still some nulls in the column |
changes:
resolve #117