Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ELBDM/UniformGranule test problem #135

Open
wants to merge 13 commits into
base: psidm
Choose a base branch
from
Open

Add ELBDM/UniformGranule test problem #135

wants to merge 13 commits into from

Conversation

HsunYeong
Copy link

Add a test problem to simulate periodic box with homogeneous FDM granule initial condition.

vivi235711
vivi235711 reviewed Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@vivi235711 vivi235711 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I left some comments here.

example/test_problem/ELBDM/UniformGranule/Input__UM_IC_RefineRegion Outdated Show resolved Hide resolved
example/test_problem/ELBDM/UniformGranule/Input__Parameter Outdated Show resolved Hide resolved
src/TestProblem/ELBDM/UniformGranule/Init_TestProb_ELBDM_UniformGranule.cpp Outdated Show resolved Hide resolved
src/TestProblem/ELBDM/UniformGranule/Init_TestProb_ELBDM_UniformGranule.cpp Outdated Show resolved Hide resolved
src/TestProblem/ELBDM/UniformGranule/Init_TestProb_ELBDM_UniformGranule.cpp Outdated Show resolved Hide resolved
example/test_problem/ELBDM/UniformGranule/python_script/get_vel_dispersion.py Outdated Show resolved Hide resolved
example/test_problem/ELBDM/UniformGranule/python_script/plot_correlation.py Outdated Show resolved Hide resolved
src/TestProblem/ELBDM/UniformGranule/Init_TestProb_ELBDM_UniformGranule.cpp Outdated Show resolved Hide resolved
src/TestProblem/ELBDM/UniformGranule/Aux_ComputeProfile_with_Sigma.cpp Outdated Show resolved Hide resolved
src/TestProblem/ELBDM/UniformGranule/Aux_ComputeProfile_with_Sigma.cpp Outdated Show resolved Hide resolved
vivi235711
vivi235711 reviewed Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@vivi235711 vivi235711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. I left some comment here.
Because I'm not familiar with the correlation function, could you please share the reference about how to calculate it? I confused why divided by std^2 or mean^2.

src/TestProblem/ELBDM/UniformGranule/Aux_ComputeProfile_with_Sigma.cpp Outdated Show resolved Hide resolved
src/TestProblem/ELBDM/UniformGranule/Aux_ComputeCorrelation.cpp Outdated Show resolved Hide resolved
src/TestProblem/ELBDM/UniformGranule/Aux_ComputeCorrelation.cpp Outdated Show resolved Hide resolved
src/TestProblem/ELBDM/UniformGranule/Aux_ComputeCorrelation.cpp Outdated Show resolved Hide resolved
src/TestProblem/ELBDM/UniformGranule/Aux_ComputeCorrelation.cpp Show resolved Hide resolved
example/test_problem/ELBDM/UniformGranule/python_script/get_vel_dispersion.py Show resolved Hide resolved
example/test_problem/ELBDM/UniformGranule/python_script/plot_correlation.py Show resolved Hide resolved
vivi235711
vivi235711 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@vivi235711 vivi235711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have one minor comment.

src/TestProblem/ELBDM/UniformGranule/Init_TestProb_ELBDM_UniformGranule.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivi235711 vivi235711 vivi235711 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HsunYeong @vivi235711