Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the accuracy and stability of the GREP routines #123

Open
wants to merge 7 commits into
base: ccsn
Choose a base branch
from
Open

Improve the accuracy and stability of the GREP routines #123

wants to merge 7 commits into from

Conversation

hfhsieh
Copy link
Collaborator

@hfhsieh hfhsieh commented May 14, 2024

  • Improve the accuracy of the effective GR potential
  • Remove the energy shift from the profile of internal energy density when adopting the nuclear EoS solver
  • Modify the tolerance from 1e-5 to 1e-10. This affects the resulting potential by a factor of < 1e-6

@hfhsieh hfhsieh added enhancement ccsn CCSN project labels May 14, 2024
@Inhyeok-Song
Copy link
Collaborator

Looks good to me.

@hyschive
Copy link
Owner

@Inhyeok-Song If everything looks fine with you, please click the Approve button

@hyschive hyschive self-assigned this May 22, 2024
ChunYen-Chen
ChunYen-Chen approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@ChunYen-Chen ChunYen-Chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I only have some super minor comments.

src/SelfGravity/CPU_Poisson/CPU_ComputeGREP.cpp Outdated Show resolved Hide resolved
src/SelfGravity/CPU_Poisson/CPU_ComputeGREP.cpp Outdated Show resolved Hide resolved
src/SelfGravity/CPU_Poisson/CPU_ComputeGREP.cpp Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunYen-Chen ChunYen-Chen ChunYen-Chen approved these changes

@Inhyeok-Song Inhyeok-Song Inhyeok-Song approved these changes

@hyschive hyschive Awaiting requested review from hyschive

Assignees

@hyschive hyschive

Labels
ccsn CCSN project enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hfhsieh @Inhyeok-Song @hyschive @ChunYen-Chen