Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LSS Simulation with
CAMB/axionCAMB
Transfer Function #122base: psidm
Are you sure you want to change the base?
LSS Simulation with
CAMB/axionCAMB
Transfer Function #122Changes from all commits
d26a599
31ad836
3081181
35a9161
bcb52ed
70b0ceb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it will be better if the constructed UM_IC with the default parameters here can match and be directly used in the default test problem like
LSS_Hybrid
(where we need one more step to convert it to UM_IC_hybrid) such that users can easily practice the procedures without changing parameters. (For now, to run inLLS
we also need to changeA_INIT
,OPT__UM_IC_NVAR
, andLSS_InitMode
.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about aligning the equal signs for a better look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if we could provide some comments to explain the meaning of these parameters and provide a tutorial about how to change them according to the user's needs, at least for those parameters we want to change frequently.