-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pickup protocol messages #1018
Conversation
5924299
to
67cee69
Compare
looking nice. is it in scope to add some tests? typically each message type will have 2 unit tests in the same file: 1 testing serialization/deserialization with minimal content/decorators, and 1 testing with maximum content/decorators. and also some tests for checking that the message type strings are determined correctly. Check the other messages in the |
Codecov Report
@@ Coverage Diff @@
## main #1018 +/- ##
==========================================
- Coverage 36.67% 35.81% -0.87%
==========================================
Files 369 381 +12
Lines 21811 21845 +34
Branches 4010 4040 +30
==========================================
- Hits 8000 7823 -177
- Misses 11653 11861 +208
- Partials 2158 2161 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Naian <[email protected]>
Signed-off-by: Naian <[email protected]>
Signed-off-by: Naian <[email protected]>
Signed-off-by: Naian <[email protected]>
Signed-off-by: Naian <[email protected]>
…in aries-vcx) Signed-off-by: Naian <[email protected]>
Signed-off-by: Naian <[email protected]>
f8c478c
to
032d00f
Compare
Ref: https://github.com/hyperledger/aries-rfcs/blob/main/features/0685-pickup-v2/README.md