Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pickup protocol messages #1018

Merged
merged 7 commits into from
Oct 19, 2023

Conversation

nain-F49FF806
Copy link
Member

@nain-F49FF806 nain-F49FF806 commented Oct 18, 2023

@nain-F49FF806 nain-F49FF806 force-pushed the nain/messages/pickup-protocol branch 2 times, most recently from 5924299 to 67cee69 Compare October 18, 2023 06:10
@gmulhearn
Copy link
Contributor

looking nice. is it in scope to add some tests? typically each message type will have 2 unit tests in the same file: 1 testing serialization/deserialization with minimal content/decorators, and 1 testing with maximum content/decorators. and also some tests for checking that the message type strings are determined correctly. Check the other messages in the messages crate for examples

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

Merging #1018 (f8c478c) into main (3f1045c) will decrease coverage by 0.87%.
The diff coverage is 2.94%.

❗ Current head f8c478c differs from pull request most recent head 032d00f. Consider uploading reports for the commit 032d00f to get more accurate results

@@            Coverage Diff             @@
##             main    #1018      +/-   ##
==========================================
- Coverage   36.67%   35.81%   -0.87%     
==========================================
  Files         369      381      +12     
  Lines       21811    21845      +34     
  Branches     4010     4040      +30     
==========================================
- Hits         8000     7823     -177     
- Misses      11653    11861     +208     
- Partials     2158     2161       +3     
Flag Coverage Δ
unittests-aries-vcx 35.81% <2.94%> (-0.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
messages/src/msg_types/registry.rs 68.75% <100.00%> (ø)
messages/src/msg_types/protocols/mod.rs 41.33% <33.33%> (-0.34%) ⬇️
messages/src/lib.rs 22.22% <0.00%> (-0.97%) ⬇️
...sg_fields/protocols/pickup/live_delivery_change.rs 0.00% <0.00%> (ø)
...c/msg_fields/protocols/pickup/messages_received.rs 0.00% <0.00%> (ø)
.../src/msg_fields/protocols/pickup/status_request.rs 0.00% <0.00%> (ø)
messages/src/decorators/transport.rs 0.00% <0.00%> (ø)
...ssages/src/msg_fields/protocols/pickup/delivery.rs 0.00% <0.00%> (ø)
...rc/msg_fields/protocols/pickup/delivery_request.rs 0.00% <0.00%> (ø)
messages/src/msg_fields/protocols/pickup/status.rs 0.00% <0.00%> (ø)
... and 3 more

... and 44 files with indirect coverage changes

messages/src/msg_fields/protocols/pickup/decorators.rs Outdated Show resolved Hide resolved
messages/src/msg_fields/protocols/pickup/decorators.rs Outdated Show resolved Hide resolved
messages/src/msg_fields/protocols/pickup/delivery.rs Outdated Show resolved Hide resolved
messages/src/msg_types/protocols/pickup.rs Outdated Show resolved Hide resolved
@Patrik-Stas Patrik-Stas merged commit 787b51c into main Oct 19, 2023
28 checks passed
@Patrik-Stas Patrik-Stas deleted the nain/messages/pickup-protocol branch October 19, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants