docs: update links to point to new website URL #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkel
reviewed
Oct 29, 2024
| @@ -67,7 +67,7 @@ class EthereumConnector extends ConnectorBase { | |||
| if (!ethereumConfig.url) { | |||
| throw new Error( | |||
| 'No URL given to access the Ethereum SUT. Please check your network configuration. ' + | |||
| 'Please see https://hyperledger.github.io/caliper/v0.3/ethereum-config/ for more info.' | |||
| 'Please see https://hyperledger-caliper.github.io/caliper/v0.3/ethereum-config/ for more info.' | |||
There was a problem hiding this comment.
The code has a reference to an old version of the docs ? If you could just delete this line and the plus sign on the previous line that would be great.
Signed-off-by: Argbet <[email protected]>
argbet21
force-pushed
the
update-links
branch
from
79bb1ef
to
ebba056
Compare
|
Alright, done! I also noticed that the link you requested to delete actually exists in the 0.6.0 version. So instead of removing it, I updated it to point to the latest Caliper version. However, let me know if it’s still preferable to remove it altogether. |
argbet21
force-pushed
the
update-links
branch
2 times, most recently
from
bfcabfc
to
db534fc
Compare
|
@argbet21 I would prefer to remove it |
Signed-off-by: Argbet <[email protected]>
argbet21
force-pushed
the
update-links
branch
from
db534fc
to
b66a0a2
Compare
|
Done! Let me know if there's anything else that's ideal to change. |
davidkel
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.