Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dev container for vscode #1643

Merged
merged 3 commits into from
Nov 12, 2024
Merged

add dev container for vscode #1643

merged 3 commits into from
Nov 12, 2024

Conversation

psankhe28
Copy link
Contributor

Checklist

  • A link to the issue/user story that the pull request relates to
  • How to recreate the problem without the fix
  • Design of the fix
  • How to prove that the fix works
  • Automated tests that prove the fix keeps on working
  • Documentation - any JSDoc, website, or Stackoverflow answers?

Issue/User story

Steps to Reproduce

Existing issues

Design of the fix

Validation of the fix

Automated Tests

What documentation has been provided for this pull request

@psankhe28
added dev container
1bf6518 
Signed-off-by: Prati28 <[email protected]>
@psankhe28 psankhe28 requested a review from a team October 19, 2024 18:08
davidkel
davidkel requested changes Oct 19, 2024
View reviewed changes
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code you also add node support into this as well, the idea would be that this dev container has everything you need to develop caliper. ie you don't have to install anything. I suggest node 20

@psankhe28
added node support
e648cf7 
Signed-off-by: Prati28 <[email protected]>
davidkel
davidkel requested changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My proposal is to remove the Dockerfile file and update devcontainer.json as proposed in the review comments.

.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/devcontainer.json Show resolved Hide resolved
@psankhe28
did the changes
8b5c4c9 
Signed-off-by: Prati28 <[email protected]>
davidkel
davidkel approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Many thanks

@davidkel davidkel merged commit cc0ada4 into hyperledger-caliper:main Nov 12, 2024
9 checks passed
@psankhe28 psankhe28 deleted the dev-container branch November 12, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkel davidkel davidkel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psankhe28 @davidkel