added contributing guide #1634
Merged
added contributing guide #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prati28 <[email protected]>
Signed-off-by: Prati28 <[email protected]>
davidkel
requested changes
Sep 14, 2024
Signed-off-by: Prati28 <[email protected]>
davidkel
requested changes
Sep 19, 2024
Signed-off-by: Prati28 <[email protected]>
davidkel
requested changes
Sep 24, 2024
CONTRIBUTING.md
Outdated
| @@ -7,6 +7,8 @@ This guideline intends to make contribtuions to Caliper easier by: | |||
|
|
|||
| If you have further suggestions about improving the guideline, then you can follow the presented workflow to make your contribution. | |||
|
|
|||
| Jump to [Contributing documentation](./docs/Contributing.md) to get started on your journey. | |||
There was a problem hiding this comment.
This is the wrong link, when I click on it I get a 404 not found. It's docs/source/contributing.md
however I am wondering whether this should link to the md file or whether it should go to the served docs (ie https://hyperledger.github.io/caliper/). For now it works. We should probably change it once we have the new docs published as the served docs presents a nicer view than just the standard md viewer.
There was a problem hiding this comment.
Yeah, after deployment I will change the link to the served docs
Signed-off-by: Prati28 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue/User story
Steps to Reproduce
Existing issues
Design of the fix
Validation of the fix
Automated Tests
What documentation has been provided for this pull request